DAOS-9917 Auto configure server side YMLs #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markaolson
requested review from
cboneti,
lsitkiew,
johannlombardi and
Kmannth
johannlombardi
previously approved these changes
Feb 25, 2022
Removed server and client config .yaml files from the images directory. Config files are no longer added in the images and expected to be modified when the instances start. Config files are now templates in terraform. The templates are rendered and added to metadata values for each instance. Then a startup script is used to get the content of the metadata values and save it to the config doas_*.yml files. This allows settings such as nr_hugepages, targets, scm_size in the config files to be set properly based on the terraform variables. The daos_server terraform module now has an output value named access_points that contains a list of the access points needed for the daos_agent.yml and daos_control.yml on the clients. Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>
Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
lsitkiew
approved these changes
Mar 1, 2022
johannlombardi
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed server and client config .yaml files from
the images directory. Config files are no longer
added in the images and expected to be modified when
the instances start.
Config files are now templates in terraform. The
templates are rendered and added to metadata values
for each instance. Then a startup script is used to
get the content of the metadata values and save it to
the config doas_*.yml files.
This allows settings such as nr_hugepages, targets, scm_size
in the config files to be set properly based on the
terraform variables.
The daos_server terraform module now has an output value
named access_points that contains a list of the access points
needed for the daos_agent.yml and daos_control.yml on the
clients.
Signed-off-by: Mark A. Olson mark.a.olson@intel.com