Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Drafter NPM Package for API Blueprint Parsing #277

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

kylef
Copy link
Collaborator

@kylef kylef commented Jul 19, 2016

This should make installing Aglio simpler. Drafter NPM package optionally depends on the C++ API Blueprint Parser (Protagonist) and uses a pure JS version if it cannot be installed. If Protagonist cannot be installed, users will still be able to install and use Aglio with the pure JS parser.

See Drafter NPM for more details.

Closes #246
Closes #249
Closes #264
Closes #201

@coveralls
Copy link

coveralls commented Jul 19, 2016

Coverage Status

Coverage remained the same at 92.473% when pulling 0a2b3f6 on kylef/drafter-npm into 4ae89e6 on master.

@danielgtaylor
Copy link
Owner

This is great. I'll be testing this out soon and will hopefully get it merged ASAP!

@khaliddermoumi
Copy link

May I kindly ask when we will get an alternative to protagonist?
The protagonist package causes a horrible amount of problems on windows.
Thanks!

@thomaschaaf
Copy link

Is there a reason to hold this pr back? It seems to work.

@pieterjandesmedt
Copy link

Come on guys, merge this already! I'm having problems with protagonist as well.

@danielgtaylor danielgtaylor merged commit dbf5ed3 into master Oct 18, 2016
@danielgtaylor danielgtaylor deleted the kylef/drafter-npm branch October 18, 2016 04:39
@danielgtaylor
Copy link
Owner

Thanks for the patience all, this is now merged. Please test and expect a release to come soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants