Enhancement/templating fix #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split index_html string in header and footer part - Use header and footer for index html template page - Fix missing html and head tags in minified index html. - Do not use templating engine for debug and can log pages, by using index html header and footer directly in generated content.
This reverts commit 04a68fc. The commit only fixed the symptoms not the cause.
This reverts commit af05f28. The original commit only fixed the symptoms, the cause has been fixed, now we ran revert these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes issue #723
Why
% characters were crashing the templating engine in the async web server component.
How
For the log pages we now bypass the templating engine. Which removes the need for a template character, and thus does not limit the characters that can appear in the log file.
This also reverts PR #724 since those changes are no longer needed.