Images with query strings are given the wrong extension

[alecgibson]

When epub-gen is provided an img with a src with a query string, then the image's extension is incorrectly changed to .bin.

For example:

<img src="http://example.com/image.jpg?w=400">

I believe the bit of the code to blame is here, where the mime package returns:

mime.lookup("http://example.com/image.jpg")       // => "image/jpeg"
mime.lookup("http://example.com/image.jpg?w=400") // => "application/octet-stream"

mime.extension("image/jpeg")                      // => "jpeg"
mime.extension("application/octet-stream")        // => "bin"

We can try to strip the query string at our end, but sometimes query strings are used to contain options for how the image is rendered (a common example being Gravatar).

It would be best if epub-gen stripped the query string when trying to determine the mediaType and extension.

[pedrosanta]

Nice catch @alecgibson. 👍 Yep, I say strip the query string from the image URL, and then mime would work well, I suppose. I can put up a PR, along with another one for #52, as soon as possible.

[pedrosanta]

It would be best if epub-gen stripped the query string when trying to determine the mediaType and extension.

Yep, just checked out on mime package and it really doesn't support URL with query strings (check broofa/mime#131)(1), so, agreed, better to update the lib to remove/ignore the query string before checking the mime types/extension.

Coming right up!

(1) - The mime lib seems more oriented to file paths and all, and author prefers that responsibility to lie outside the mime lib so, no point raising an issue there/upstream I suppose. 🙂

[pedrosanta]

Fixed on v0.0.19. Closing.