fix: ensure that find-process does not error out due to a bad regex #30380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Run status |
|
| Run duration | 12m 36s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
233
|
UI Coverage
67.07%
|
|
|---|---|
|
Untested elements
|
25
|
|
Tested elements
|
55
|
Accessibility
96.17%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
199
|
mschile
approved these changes
Oct 9, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cypress runon windows: TypeError: Cannot read properties of undefined (reading 'trim') #30378Additional details
find-processhas a bug in their code where they are doing:The problem with that is (from mdn)
If separator is a regular expression with capturing groups, then each time separator matches, the captured groups (including any undefined results) are spliced into the output array.We fix this by patching their project to use one capture group which will not generate any undefined results.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?