Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependency): Upgrade Electron 27 #28792

Merged
merged 99 commits into from
Feb 15, 2024
Merged

chore(dependency): Upgrade Electron 27 #28792

merged 99 commits into from
Feb 15, 2024

Conversation

cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Jan 24, 2024 •
edited by jennifer-shehane
Loading

Additional details

Upgrades our binary to use Electron 27.

Steps to test

How has the user experience changed?

PR Tasks

cacieprins and others added 30 commits December 11, 2023 09:27
@cacieprins
dependency: upgrades electron from 25 to 26
8a6c4ab
@cacieprins
bump cache run ci
a89659c
@cacieprins
fix docker img names
139487b
@cacieprins
ref electron upgrade branch
f3229ed
chore: updating v8 snapshot cache
3a453b0
chore: updating v8 snapshot cache
032a165
chore: updating v8 snapshot cache
185cf86
@cacieprins
debug
45a220e
@cacieprins
debug
c1fcdb1
@cacieprins
debug
509e499
@cacieprins
update search string for resize observer error swallow
7912db2
@cacieprins
debug
f875b0a
@cacieprins
update integrity check
b1c1d52
@cacieprins
update electron readme with upgrade troubleshooting section
58b1349
@cacieprins
point to new publish binary workflow branch for electron 27
b32a1e2
@cacieprins
update electron readme with locations of chromium & node versions for…
3bb82dd 
… a given electron version
@cacieprins
update node versions and docker image refs
a0bd74d
@cacieprins
update electron version to 27.1.3
1066e37
@cacieprins
fix db nativeBinding arg
acaaea6
chore: updating v8 snapshot cache
b76511d
@cacieprins
install setuptools on mac when updating v8 snapshot cache
eae7513
chore: updating v8 snapshot cache
a6ac000
chore: updating v8 snapshot cache
e7e48ad
@cacieprins
run workflows on this branch run ci
f843948
@cacieprins
require addon directly and pass to better-sqlite3 init; debug
6e64ceb
@cacieprins
rm debug
9a3af58
@cacieprins
try loading better-sqlite with a more dynamic filename
a63fde1
@ryanthemanuel
bump electron version
3961271
@ryanthemanuel
bump electron version
4e0d91e
@ryanthemanuel
bump electron version -- run ci
7d80f77
@AtofStryker AtofStryker self-requested a review January 29, 2024 17:17
astone123
astone123 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

cacieprins and others added 20 commits January 30, 2024 15:04
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
2f934cd
@cacieprins
debug app e2e test
e5a16e3
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
7c87a94
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
f707c63
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
b9ed0a7
@cacieprins
bump cache
eeba3b3
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
c4c4668
@cacieprins
upgrade browsers-internal to chrome 121
efb9846
@cacieprins
revert to chrome 118 images
149d244
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
7c5e0ee
@cacieprins
bump cache
eda9c15
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
a5e8680
chore: updating v8 snapshot cache
a6456f3
chore: updating v8 snapshot cache
b6f6e17
chore: updating v8 snapshot cache
ca5965c
@cacieprins
bump cache
b7ed3e4
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
ac0ece3
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
bef8dcd
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
d930eb1
@cacieprins
Merge branch 'develop' into cacie/dep/electron-27
5e559ed
@cacieprins cacieprins merged commit 3288aa5 into develop Feb 15, 2024
122 of 129 checks passed
@cacieprins cacieprins deleted the cacie/dep/electron-27 branch February 15, 2024 15:33
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 20, 2024

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanthemanuel ryanthemanuel ryanthemanuel left review comments

@astone123 astone123 astone123 approved these changes

@AtofStryker AtofStryker AtofStryker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Electron 27 (or latest)
4 participants
@cacieprins @AtofStryker @ryanthemanuel @astone123