Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding emergency garbage collection at 90% for chromium-based browsers #25521

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Jan 19, 2023

Edit: Reverted in #25546

  • Closes n/a

User facing changelog

n/a

Additional details

In an effort to reduce OOM errors, we decided to perform a GC when the browser's renderer process reaches 90% of the available memory.

Steps to test

How has the user experience changed?

n/a

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/s] Have API changes been updated in the type definitions?

@mjhenkes mjhenkes self-requested a review January 19, 2023 20:32
@cypress
Copy link

cypress bot commented Jan 19, 2023



Test summary

26572 0 1281 0Flakiness 40


Run details

Project cypress
Status Passed
Commit 6f15a10
Started Jan 19, 2023 8:13 PM
Ended Jan 19, 2023 8:33 PM
Duration 19:28 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

create-from-component.cy.ts Flakiness
1 ... > runs generated spec
2 ... > runs generated spec
commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
2 network stubbing > intercepting request > can delay and throttle a StaticResponse
3 ... > with `times` > only uses each handler N times
This comment includes only the first 5 flaky tests. See all 40 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mschile mschile merged commit 83b2cc1 into develop Jan 19, 2023
@mschile mschile deleted the mschile/emergency_gc branch January 19, 2023 21:01
mschile added a commit that referenced this pull request Jan 23, 2023
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 24, 2023
@cypress-io cypress-io deleted a comment from cypress-bot bot Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants