Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ESLint
9.x
identifies usages in the repo of unnecessary ESLint rule disables.This affects the following instances:
/* eslint-disable-next-line no-console */
inThe ESLint no-console rule does not belong to the set of recommended rules in ESLint
8.x
or9.x
and so disabling it in-line was not necessary./* eslint-disable no-unused-vars */
inESLint finds no unused variables in the marked section.
Process
By temporarily updating to ESLint
9.x
, unnecessary rule disables are identified and automatically removed byeslint --fix
Run ESLint
9.x
:Revert to ESLint
8.x
and check that linting still works:Changes
This prepares the Cypress test specs so that they will pass linting when the repo is migrated to ESLint
9.x
.Verification
On Ubuntu
22.04.4
LTS, Node.jsv20.12.2
LTS