Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve City, Postal Town and Neightbourhood logic #285

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Jun 2, 2024

Based on the OpenStreetMap wiki on the different steps of the place key: https://wiki.openstreetmap.org/wiki/Key:place

Finds the first of these OSM place keys that is set to use for the places city attribute:
city, town, village, township, hamlet, city_district, municipality

Then finds the first of these OSM place keys that is set below the one used for city to use for the places postal_town attribute:
city, town, village, township, hamlet, borough, suburb

Then finds the first of these OSM place keys that is set below the one used for postal_town to use for the places neighbourhood attribute:
village, township, hamlet, borough, suburb, quarter, neighbourhood

Fixes #282

@Snuffy2 Snuffy2 force-pushed the Fix-postal-town branch 2 times, most recently from 860207a to 0b1db79 Compare June 2, 2024 17:00
@Snuffy2 Snuffy2 changed the title Fix-postal-town Improve City, Postal Town and Neightbourhood logic Jun 2, 2024
@Snuffy2 Snuffy2 force-pushed the Fix-postal-town branch from 0b1db79 to 352d7c2 Compare June 2, 2024 17:12
@Snuffy2 Snuffy2 force-pushed the Fix-postal-town branch from 352d7c2 to cc28017 Compare June 2, 2024 17:17
@Snuffy2 Snuffy2 marked this pull request as ready for review June 2, 2024 17:31
@Snuffy2 Snuffy2 merged commit 743898f into custom-components:master Jun 4, 2024
3 checks passed
@Snuffy2 Snuffy2 deleted the Fix-postal-town branch June 4, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postal Town regularly not populated
2 participants