Reserved memory #125
Merged
Reserved memory #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tomwhite
force-pushed
the
reserved-memory
branch
from
81219f3 to
959ef10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59.
Adds a
reserved_memparameter to the spec. The idea is thatmax_mem + reserved_memshould never exceed the total worker memory. This is not checked for, but could be via #110.In the future we might want to change it so you specify
total_memandreserved_mem(using themeasure_reserved_memfunction), and the system usesmax_mem = total_mem - reserved_mem.