-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double-pass image extractor #48
Merged
HealthyPear
merged 9 commits into
cta-observatory:master
from
HealthyPear:feature-2ndPassImageExtractor
Feb 27, 2020
Merged
Double-pass image extractor #48
HealthyPear
merged 9 commits into
cta-observatory:master
from
HealthyPear:feature-2ndPassImageExtractor
Feb 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to use the new image extractor, but it introduced a redundancy. Later this function could export only the subbarray and from write_dl1 the new script version should take over.
HealthyPear
added
enhancement
New feature or request
pipeline applications
Application of the pipeline to specific studies
labels
Feb 26, 2020
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage ? 0.4%
=======================================
Files ? 20
Lines ? 2221
Branches ? 0
=======================================
Hits ? 9
Misses ? 2212
Partials ? 0
Continue to review full report at Codecov.
|
kosack
approved these changes
Feb 27, 2020
HealthyPear
removed
the
pipeline applications
Application of the pipeline to specific studies
label
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This feature is relevant for issues #24, and in particular for issues #31 and #37 .
It has been already pushed to ctapipe (see cta-observatory/ctapipe#1215 for details).
This version complies with the conda-packaged version of ctapipe 0.7, so expect some (not performance-related) differences.
Caveats:
calibration_status
(only for the optionalimages.h5
file); such variable records if an image doesn't survive the 1st pass OR survives it but the image-width from the fit between the 2 passes is NaN; for the previous point, this is of course useless now (since only good images are exported), but I decided to keep it here if we decide to implement this functionality later on.