-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed missing import of QTable #188
fixed missing import of QTable #188
Conversation
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 63.06% 63.11% +0.05%
==========================================
Files 28 28
Lines 2886 2890 +4
==========================================
+ Hits 1820 1824 +4
Misses 1066 1066
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add QTable
to the entries that automodapi
should skip (protopipe/docs/benchmarks.rst
)
Actually, that's not normally needed: it is however missing an |
Oh I didn't know. Then if that works it's fine for me. |
Yeah, if a module doesn't have an |
I this is the case, I guess we can then also remove the |
Actually we have to: the 2 things together generate warnings, which are set to be trated as errors by the documentation build on readthedocs (which for the moment is the only versioned one, even though #175 will add support for versioning also when building elsewhere) |
…k/protopipe into fix/missing_import_plot_py
…into fix/missing_import_plot_py
…into fix/missing_import_plot_py
(also ran isort to optimize imports)