Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ctapipe 0.10.5 #124

Merged

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Apr 1, 2021

This PR is a requirement for PR #110, which started in the same way, but I preferred to split API upgrade from the refactoring based on ctapipe.core.Tools.

Now all ctapipe-related API is based on ctapipe 0.10.5.

I also introduced a new conda environment file for released versions.

@HealthyPear HealthyPear added enhancement New feature or request dependency stuff related to the dependencies of the package labels Apr 1, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Apr 1, 2021
@HealthyPear HealthyPear requested a review from kosack April 1, 2021 09:43
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #124 (23dc1be) into master (b58e7ec) will decrease coverage by 1.04%.
The diff coverage is 49.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   49.97%   48.92%   -1.05%     
==========================================
  Files          22       22              
  Lines        1995     2001       +6     
==========================================
- Hits          997      979      -18     
- Misses        998     1022      +24     
Impacted Files Coverage Δ
protopipe/scripts/write_dl2.py 4.90% <3.44%> (-0.74%) ⬇️
protopipe/pipeline/utils.py 56.89% <81.81%> (+1.13%) ⬆️
protopipe/pipeline/event_preparer.py 69.34% <100.00%> (-7.28%) ⬇️
protopipe/scripts/data_training.py 94.59% <100.00%> (-0.06%) ⬇️
protopipe/_dev_version.py 60.00% <0.00%> (-20.00%) ⬇️
protopipe/version.py 36.36% <0.00%> (-18.19%) ⬇️
protopipe/pipeline/temp.py 74.82% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b58e7ec...23dc1be. Read the comment docs.

@HealthyPear HealthyPear merged commit 166fbe0 into cta-observatory:master Apr 12, 2021
@HealthyPear HealthyPear deleted the upgrade-ctapipe_0.10.5 branch April 12, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency stuff related to the dependencies of the package enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants