Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes some mild progress towards improving the quality of the point validation functions.
Most of the important issues have been discussed on IRC, but some key points where things will need to change in the future (but are not implemented in this pull request) are:
params.curve.params
to becurve.params
, that is, return a curve object fromnames.js
, not a parameters object.Curve
object and remove thePoint
object completely.It is just bloat, and there should never be a case where two points are not in the same curve context and group operations performed. So it is useless storage and a possibility for error.