Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Terraform provider version to v3.55.0 #449

Merged
merged 2 commits into from
May 15, 2023
Merged

Bump Terraform provider version to v3.55.0 #449

merged 2 commits into from
May 15, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented May 10, 2023 •
edited
Loading

Description of your changes

Bumps Terraform provider version to v3.55.0.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Breaking CRD schema changes

NAME                                                   READY   SYNCED   EXTERNAL-NAME           AGE
resourcegroup.azure.upbound.io/example-rg-dbformysql   True    True     example-rg-dbformysql   67m

NAME                                                         READY   SYNCED   EXTERNAL-NAME     AGE
flexibleserver.dbformysql.azure.upbound.io/example-upbound   True    True     example-upbound   67m

NAME                                                            READY   SYNCED   EXTERNAL-NAME           AGE
virtualnetwork.network.azure.upbound.io/example-vn-dbformysql   True    True     example-vn-dbformysql   67m

NAME                                                        READY   SYNCED   EXTERNAL-NAME               AGE
subnet.network.azure.upbound.io/example-subnet-dbformysql   True    True     example-subnet-dbformysql   67m

NAME                                                                        READY   SYNCED   EXTERNAL-NAME     AGE
privatednszonevirtualnetworklink.network.azure.upbound.io/example-upbound   True    True     example-upbound   67m

NAME                                                      READY   SYNCED   EXTERNAL-NAME                              AGE
privatednszone.network.azure.upbound.io/example-upbound   True    True     example-upbound.mysql.database.azure.com   67m

NAME                                             READY   SYNCED   EXTERNAL-NAME     AGE
resourcegroup.azure.upbound.io/linuxfuncapp-rg   True    True     linuxfuncapp-rg   10m

NAME                                               READY   SYNCED   EXTERNAL-NAME     AGE
account.storage.azure.upbound.io/linuxfuncappacc   True    True     linuxfuncappacc   10m

NAME                                                  READY   SYNCED   EXTERNAL-NAME
                                                                         AGE
linuxfunctionapp.web.azure.upbound.io/linuxappexmpl   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/reso
urceGroups/linuxfuncapp-rg/providers/Microsoft.Web/sites/linuxappexmpl   10m

NAME                                               READY   SYNCED   EXTERNAL-NAME     AGE
serviceplan.web.azure.upbound.io/linuxfuncapp-sp   True    True     linuxfuncapp-sp   10m
  • web.azure.upbound.io_linuxfunctionappslots.yaml, Manually
NAME                                                  READY   SYNCED   EXTERNAL-NAME          AGE
resourcegroup.azure.upbound.io/linuxfuncnappslot-rg   True    True     linuxfuncnappslot-rg   27m

NAME                                                    READY   SYNCED   EXTERNAL-NAME          AGE
account.storage.azure.upbound.io/linuxfuncnappslotacc   True    True     linuxfuncnappslotacc   27m

NAME                                                         READY   SYNCED   EXTERNAL-NAME
                                                                                            AGE
linuxfunctionapp.web.azure.upbound.io/linuxfuncnappslotapp   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610
a8/resourceGroups/linuxfuncnappslot-rg/providers/Microsoft.Web/sites/linuxfuncnappslotapp   27m

NAME                                                    READY   SYNCED   EXTERNAL-NAME          AGE
serviceplan.web.azure.upbound.io/linuxfuncnappslot-sp   True    True     linuxfuncnappslot-sp   27m

NAME                                                       READY   SYNCED   EXTERNAL-NAME    AGE
linuxfunctionappslot.web.azure.upbound.io/examplelinslot   True    True     examplelinslot   27m
  • web.azure.upbound.io_linuxwebapps.yaml, Manually
NAME                                            READY   SYNCED   EXTERNAL-NAME    AGE
resourcegroup.azure.upbound.io/linuxwebapp-rg   True    True     linuxwebapp-rg   77m

NAME                                               READY   SYNCED   EXTERNAL-NAME     AGE
linuxwebapp.web.azure.upbound.io/linuxappexample   True    True     linuxappexample   78m

NAME                                              READY   SYNCED   EXTERNAL-NAME    AGE
serviceplan.web.azure.upbound.io/linuxwebapp-sp   True    True     linuxwebapp-sp   78m
  • web.azure.upbound.io_linuxwebappslots.yaml, Manually
NAME                                                READY   SYNCED   EXTERNAL-NAME        AGE
resourcegroup.azure.upbound.io/linuxwebappslot-rg   True    True     linuxwebappslot-rg   12m

NAME                                                  READY   SYNCED   EXTERNAL-NAME        AGE
serviceplan.web.azure.upbound.io/linuxwebappslot-sp   True    True     linuxwebappslot-sp   12m

NAME                                                     READY   SYNCED   EXTERNAL-NAME
                                                                                                             AGE
linuxwebappslot.web.azure.upbound.io/lnxappslotexample   True    True     /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/r
esourceGroups/linuxwebappslot-rg/providers/Microsoft.Web/sites/linuxwebappslot-lwa/slots/lnxappslotexample   12m

NAME                                                   READY   SYNCED   EXTERNAL-NAME         AGE
linuxwebapp.web.azure.upbound.io/linuxwebappslot-lwa   True    True     linuxwebappslot-lwa   12m
  • web.azure.upbound.io_windowsfunctionapps.yaml, Manually
NAME                                               READY   SYNCED   EXTERNAL-NAME       AGE
resourcegroup.azure.upbound.io/winfunctionapp-rg   True    True     winfunctionapp-rg   8m5s

NAME                                                 READY   SYNCED   EXTERNAL-NAME       AGE
account.storage.azure.upbound.io/winfunctionappacc   True    True     winfunctionappacc   8m8s

NAME                                                               READY   SYNCED   EXTERNAL-NAME              AGE
windowsfunctionapp.web.azure.upbound.io/windowsfunctionappnameaa   True    True     windowsfunctionappnameaa   8m8s

NAME                                                 READY   SYNCED   EXTERNAL-NAME       AGE
serviceplan.web.azure.upbound.io/winfunctionapp-rg   True    True     winfunctionapp-rg   8m8s
  • web.azure.upbound.io_windowsfunctionappslots.yaml, Manually
NAME                                               READY   SYNCED   EXTERNAL-NAME       AGE
resourcegroup.azure.upbound.io/winfuncappslot-rg   True    True     winfuncappslot-rg   9m11s

NAME                                                 READY   SYNCED   EXTERNAL-NAME       AGE
account.storage.azure.upbound.io/winfuncappslotacc   True    True     winfuncappslotacc   9m13s

NAME                                                                READY   SYNCED   EXTERNAL-NAME           AGE
windowsfunctionappslot.web.azure.upbound.io/examplewinfuncappslot   True    True     examplewinfuncappslot   9m13s

NAME                                                          READY   SYNCED   EXTERNAL-NAME         AGE
windowsfunctionapp.web.azure.upbound.io/winfuncappslot-wapp   True    True     winfuncappslot-wapp   9m13s

NAME                                                 READY   SYNCED   EXTERNAL-NAME       AGE
serviceplan.web.azure.upbound.io/winfuncappslot-sp   True    True     winfuncappslot-sp   9m13s
  • web.azure.upbound.io_windowswebapps.yaml, Manually
NAME                                     READY   SYNCED   EXTERNAL-NAME   AGE
resourcegroup.azure.upbound.io/example   True    True     example         4m40s

NAME                                       READY   SYNCED   EXTERNAL-NAME   AGE
serviceplan.web.azure.upbound.io/example   True    True     example         4m43s

NAME                                                    READY   SYNCED   EXTERNAL-NAME        AGE
windowswebapp.web.azure.upbound.io/windowswebappnamea   True    True     windowswebappnamea   4m43s
  • web.azure.upbound.io_windowswebappslots.yaml, Manually
NAME                                     READY   SYNCED   EXTERNAL-NAME   AGE
resourcegroup.azure.upbound.io/slot-rg   True    True     slot-rg         19m

NAME                                       READY   SYNCED   EXTERNAL-NAME   AGE
serviceplan.web.azure.upbound.io/example   True    True     example         19m

NAME                                                   READY   SYNCED   EXTERNAL-NAME       AGE
windowswebapp.web.azure.upbound.io/windowswebappname   True    True     windowswebappname   19m

NAME                                             READY   SYNCED   EXTERNAL-NAME   AGE
windowswebappslot.web.azure.upbound.io/example   True    True     example         19m

Native state schema version changes

@turkenf turkenf force-pushed the update-tf-provider-3.55.0 branch from 7c7add0 to 5b13b96 Compare May 10, 2023 19:52
@turkenf turkenf force-pushed the update-tf-provider-3.55.0 branch from 5b13b96 to bedda56 Compare May 10, 2023 19:53
@turkenf turkenf closed this May 10, 2023
@turkenf turkenf reopened this May 10, 2023
@turkenf turkenf closed this May 10, 2023
@turkenf turkenf reopened this May 10, 2023
@turkenf turkenf closed this May 11, 2023
@turkenf turkenf reopened this May 11, 2023
@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/cognitiveservices/account.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/insights/monitorscheduledqueryrulesalert.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/network/webapplicationfirewallpolicy.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/web/linuxfunctionapp.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/web/linuxfunctionappslot.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/web/linuxfunctionapp.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/web/linuxwebapp.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/web/linuxfunctionapp.yaml"

1 similar comment
@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/web/linuxfunctionapp.yaml"

@turkenf turkenf force-pushed the update-tf-provider-3.55.0 branch from 8be221d to 29ea264 Compare May 11, 2023 18:04
@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/web/linuxwebapp.yaml"

@turkenf
Fix example manifests for the following resources:
f252d9a 
- azurerm_linux_function_app
- azurerm_linux_function_app_slot
@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/web/linuxfunctionapp.yaml"

@turkenf turkenf force-pushed the update-tf-provider-3.55.0 branch from 29ea264 to f252d9a Compare May 11, 2023 21:04
@turkenf
Copy link
Collaborator Author

turkenf commented May 11, 2023

/test-examples="examples/search/service.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 12, 2023

/test-examples="examples/iotcentral/application.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 12, 2023

Thi PR is ready for review.

sergenyalcin
sergenyalcin approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM!

@turkenf turkenf merged commit cf36950 into crossplane-contrib:main May 15, 2023
@turkenf turkenf deleted the update-tf-provider-3.55.0 branch May 15, 2023 08:45
@turkenf turkenf mentioned this pull request May 15, 2023
Closed
1 task
@cychiang cychiang mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergenyalcin sergenyalcin sergenyalcin approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turkenf @sergenyalcin