Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ESS Plugin #440

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Enable ESS Plugin #440

merged 2 commits into from
Apr 26, 2023

Conversation

turkenh
Copy link
Contributor

@turkenh turkenh commented Apr 26, 2023

Description of your changes

This PR consumes relevant Upjet changes and loads TLS config for ESS plugin if the path is set.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Code compiles.
I would lean on the testing done in crossplane-contrib/provider-upjet-aws#677 as the changes are mostly mechanical.

turkenh added 2 commits April 26, 2023 12:23
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenh, lgtm.

@turkenh turkenh merged commit 242cb8d into crossplane-contrib:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants