Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Terraform provider version to v3.45.0 #392

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

svscheg
Copy link
Contributor

@svscheg svscheg commented Feb 28, 2023

Description of your changes

Bumps Terraform provider version to v3.45.0

Fixes #391

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

crddiff reports breaking changes in the following resources:

state schema version reports breaking changes in the following resources:

Manual intervention for state schema version changes:

  • cache.RedisCache

Screenshot 2023-03-02 at 23 45 43

`manual-intervention` with issue - /~https://github.com/upbound/official-providers/issues/629 Schema changes fix: changing the external-name syntax - will need to make the `R` lower case in the `Redis ` path component in this example ('Redis' -> 'redis')

Screenshot 2023-03-02 at 23 45 43

Schema changes fix: changing the external-name syntax - will need to make the R lower case in the Redis path component in this example ('Redis' -> 'redis')

image

Schema changes fix: changing the external-name syntax - will need to make the R lower case in the Redis path component in this example ('Redis' -> 'redis')
Also fixed the external name, will use next configuration: confi.TemplatedStringAsIdentifier("", "/subscriptions/{{ .setup.configuration.subscription_id }}/resourceGroups/{{ .parameters.resource_group_name }}/providers/Microsoft.Cache/redis/{{ .parameters.target_redis_cache_name }}/linkedServers/{{ .parameters.linked_redis_cache_name }}"),

@svscheg
Copy link
Contributor Author

svscheg commented Mar 1, 2023

/test-examples="examples/storage/managementpolicy.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Mar 1, 2023

/test-examples="examples/databricks/accessconnector.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Mar 2, 2023

/test-examples="examples/storage/managementpolicy.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Mar 2, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Mar 2, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Mar 2, 2023

/test-examples="examples/operationalinsights/workspace.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Mar 2, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

@svscheg svscheg force-pushed the tf-provider-3.45.0 branch from 70ea6ec to d4bb7c2 Compare March 3, 2023 10:33
@svscheg svscheg requested a review from sergenyalcin as a code owner March 3, 2023 10:33
@svscheg svscheg removed the request for review from sergenyalcin March 3, 2023 11:18
@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/securityinsights/sentinelloganalyticsworkspaceonboarding.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

@svscheg svscheg force-pushed the tf-provider-3.45.0 branch from d4bb7c2 to 94c294a Compare March 3, 2023 15:31
@svscheg svscheg requested a review from ulucinar as a code owner March 3, 2023 15:31
@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/securityinsights/sentinelloganalyticsworkspaceonboarding.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/securityinsights/sentinelloganalyticsworkspaceonboarding.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

@svscheg svscheg force-pushed the tf-provider-3.45.0 branch from 94c294a to 0ab52ac Compare March 3, 2023 18:29
@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

@svscheg svscheg force-pushed the tf-provider-3.45.0 branch from 0ab52ac to 4975e46 Compare March 3, 2023 22:20
@svscheg
Copy link
Contributor Author

svscheg commented Mar 3, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Mar 4, 2023

/test-examples="examples/kusto/clustermanagedprivateendpoint.yaml"

@svscheg svscheg force-pushed the tf-provider-3.45.0 branch from 102f92b to 5a4e483 Compare March 6, 2023 16:37
@svscheg svscheg requested a review from sergenyalcin March 8, 2023 07:40
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svscheg LGTM!

@svscheg svscheg merged commit e7e0002 into crossplane-contrib:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to the latest upstream Terraform provider
2 participants