Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving spring_cloud(2) resources to v1beta1 version #368

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

svscheg
Copy link
Contributor

@svscheg svscheg commented Feb 19, 2023

@svscheg svscheg force-pushed the spring_cloud_2resources branch from f966c5b to 1c50f24 Compare February 19, 2023 15:07
@svscheg
Copy link
Contributor Author

svscheg commented Feb 19, 2023

/test-examples="examples/appplatform/springcloudapiportalcustomdomain.yaml"

@svscheg svscheg force-pushed the spring_cloud_2resources branch 2 times, most recently from 8aeea6d to e44c68f Compare February 19, 2023 17:31
@svscheg
Copy link
Contributor Author

svscheg commented Feb 19, 2023

/test-examples="examples/appplatform/springcloudapiportalcustomdomain.yaml"

@svscheg svscheg force-pushed the spring_cloud_2resources branch 2 times, most recently from 8749f6d to 3422895 Compare February 19, 2023 18:25
@svscheg
Copy link
Contributor Author

svscheg commented Feb 19, 2023

/test-examples="examples/appplatform/springcloudapiportalcustomdomain.yaml"

@svscheg svscheg force-pushed the spring_cloud_2resources branch from 3422895 to fb2e29c Compare February 19, 2023 19:32
@svscheg
Copy link
Contributor Author

svscheg commented Feb 19, 2023

/test-examples="examples/appplatform/springcloudapiportalcustomdomain.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 19, 2023

/test-examples="examples/servicelinker/springcloudconnection.yaml"

@svscheg svscheg force-pushed the spring_cloud_2resources branch from fb2e29c to 71801ac Compare February 19, 2023 21:00
@svscheg
Copy link
Contributor Author

svscheg commented Feb 19, 2023

/test-examples="examples/servicelinker/springcloudconnection.yaml"

2 similar comments
@svscheg
Copy link
Contributor Author

svscheg commented Feb 19, 2023

/test-examples="examples/servicelinker/springcloudconnection.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 19, 2023

/test-examples="examples/servicelinker/springcloudconnection.yaml"

@svscheg svscheg force-pushed the spring_cloud_2resources branch 3 times, most recently from a9b7a3d to 3d7f984 Compare February 20, 2023 11:31
@svscheg
Copy link
Contributor Author

svscheg commented Feb 20, 2023

/test-examples="examples/servicelinker/springcloudconnection.yaml"

@svscheg svscheg requested a review from sergenyalcin February 20, 2023 14:05
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svscheg LGTM!

@svscheg svscheg force-pushed the spring_cloud_2resources branch from 3d7f984 to 001bba4 Compare February 20, 2023 19:08
@svscheg svscheg merged commit 01ccc94 into crossplane-contrib:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving spring_cloud(2) resources to v1beta1 version
2 participants