-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving spring_cloud(2) resources to v1beta1 version #368
Moving spring_cloud(2) resources to v1beta1 version #368
Conversation
f966c5b
to
1c50f24
Compare
/test-examples="examples/appplatform/springcloudapiportalcustomdomain.yaml" |
8aeea6d
to
e44c68f
Compare
/test-examples="examples/appplatform/springcloudapiportalcustomdomain.yaml" |
8749f6d
to
3422895
Compare
/test-examples="examples/appplatform/springcloudapiportalcustomdomain.yaml" |
3422895
to
fb2e29c
Compare
/test-examples="examples/appplatform/springcloudapiportalcustomdomain.yaml" |
/test-examples="examples/servicelinker/springcloudconnection.yaml" |
fb2e29c
to
71801ac
Compare
/test-examples="examples/servicelinker/springcloudconnection.yaml" |
2 similar comments
/test-examples="examples/servicelinker/springcloudconnection.yaml" |
/test-examples="examples/servicelinker/springcloudconnection.yaml" |
a9b7a3d
to
3d7f984
Compare
/test-examples="examples/servicelinker/springcloudconnection.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @svscheg LGTM!
3d7f984
to
001bba4
Compare
Description of your changes
spring_cloud
2Fixes #328
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manually
Uptest
azurerm_spring_cloud_connection - /~https://github.com/upbound/provider-azure/actions/runs/4223027133
azurerm_spring_cloud_api_portal_custom_domain - /~https://github.com/upbound/provider-azure/actions/runs/4217846290