Moving machinelearningservices(1), maintenance(3), managed(1) to v1beta1 version #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svscheg
force-pushed
the
logz_machinelearningservices_maintenance_managed
branch
2 times, most recently
from
6546c7c to
0843448
Compare
|
/test-examples="examples/machinelearningservices/synapsespark.yaml" |
|
/test-examples="examples/compute/manageddisksastoken.yaml" |
dverveiko
reviewed
Feb 17, 2023
svscheg
force-pushed
the
logz_machinelearningservices_maintenance_managed
branch
2 times, most recently
from
4eccba8 to
8c5391f
Compare
svscheg
changed the title
svscheg
force-pushed
the
logz_machinelearningservices_maintenance_managed
branch
2 times, most recently
from
d8b8152 to
5df3134
Compare
|
/test-examples="examples/compute/manageddisksastoken.yaml" |
|
/test-examples="examples/machinelearningservices/workspace.yaml" |
|
/test-examples="examples/maintenance/maintenanceassignmentvirtualmachine.yaml" |
|
/test-examples="examples/maintenance/maintenanceconfiguration.yaml" |
1 similar comment
|
/test-examples="examples/maintenance/maintenanceconfiguration.yaml" |
svscheg
force-pushed
the
logz_machinelearningservices_maintenance_managed
branch
from
5df3134 to
f4b4b08
Compare
|
/test-examples="examples/maintenance/maintenanceconfiguration.yaml" |
svscheg
force-pushed
the
logz_machinelearningservices_maintenance_managed
branch
2 times, most recently
from
50ec59f to
74234c8
Compare
sergenyalcin
approved these changes
Feb 21, 2023
svscheg
force-pushed
the
logz_machinelearningservices_maintenance_managed
branch
from
74234c8 to
4be48a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
machinelearningservicesgroup:azurerm_machine_learning_workspacemaintenancegroup:azurerm_maintenance_assignment_dedicated_hostazurerm_maintenance_assignment_virtual_machineazurerm_maintenance_configurationmanagedgroup:azurerm_managed_disk_sas_tokenFixes #270
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually
maintenancegroup:azurerm_maintenance_assignment_dedicated_host- This resource requires DedicatedHost resource which need manual intervention.azurerm_maintenance_assignment_virtual_machine- Unstable resource. Passed on manual runs with True condition and kubectl annotate managed --all upjet.upbound.io/test=true --overwriteazurerm_maintenance_configuration- Unstable resource. Passed on manual runs with True condition and kubectl annotate managed --all upjet.upbound.io/test=true --overwriteUptest
machinelearningservicesgroup:azurerm_machine_learning_workspace- /~https://github.com/upbound/provider-azure/actions/runs/4223842981managedgroup:azurerm_managed_disk_sas_token- /~https://github.com/upbound/provider-azure/actions/runs/4223689715