Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving hdinsight(5), healthbot(1), healthcare(3) resources to v1beta1 version #305

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Moving hdinsight(5), healthbot(1), healthcare(3) resources to v1beta1 version #305

merged 1 commit into from
Feb 8, 2023

Conversation

svscheg
Copy link
Contributor

@svscheg svscheg commented Feb 3, 2023 •
edited
Loading

Description of your changes

Moving hdinsight 5 resources to v1beta1 version

Moving healthbot 1 resources to v1beta1 version

Moving healthcare 3 resources to v1beta1 version

Fixes #226

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually
Uptests
Moving hdinsight 5 resources to v1beta1 version

Moving healthbot 1 resources to v1beta1 version

Moving healthcare 3 resources to v1beta1 version

@svscheg svscheg force-pushed the hardwaresecuritymodules_hdinsight_healthbot_healthcare branch 2 times, most recently from ca0da8e to 86a3a70 Compare February 3, 2023 15:41
@svscheg
Copy link
Contributor Author

svscheg commented Feb 3, 2023

/test-examples="examples/hdinsight/hadoopcluster.yaml"

3 similar comments
@svscheg
Copy link
Contributor Author

svscheg commented Feb 3, 2023

/test-examples="examples/hdinsight/hadoopcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 3, 2023

/test-examples="examples/hdinsight/hadoopcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 4, 2023

/test-examples="examples/hdinsight/hadoopcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 4, 2023

/test-examples="examples/hdinsight/hbasecluster.yaml"

2 similar comments
@svscheg
Copy link
Contributor Author

svscheg commented Feb 4, 2023

/test-examples="examples/hdinsight/hbasecluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 4, 2023

/test-examples="examples/hdinsight/hbasecluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 4, 2023

/test-examples="examples/hdinsight/interactivequerycluster.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Feb 4, 2023

/test-examples="examples/hdinsight/interactivequerycluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples/hdinsight/kafkacluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples-generated/hdinsight/sparkcluster.yaml"

5 similar comments
@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples-generated/hdinsight/sparkcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples-generated/hdinsight/sparkcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples-generated/hdinsight/sparkcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples-generated/hdinsight/sparkcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples-generated/hdinsight/sparkcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples-generated/healthbot/healthbot.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples/healthcareapis/healthcaredicomservice.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples/healthcareapis/healthcarefhirservice.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples/healthcareapis/healthcarefhirservice.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples/healthcareapis/healthcareworkspace.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples-generated/hdinsight/sparkcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples/hdinsight/sparkcluster.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples/healthbot/healthbot.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Feb 5, 2023

/test-examples="examples/hdinsight/sparkcluster.yaml"

@svscheg svscheg force-pushed the hardwaresecuritymodules_hdinsight_healthbot_healthcare branch from 86a3a70 to e531ab1 Compare February 7, 2023 20:13
turkenf
turkenf approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svscheg

examples/hdinsight/testhooks/delete-hadoopcluster.sh
set -aeuo pipefail

# the HadoopCluster resource should be deleted before Container
${KUBECTL} delete hadoopcluster.hdinsight.azure.upbound.io --all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: using labels instead of --all could be better.
see this as an example: /~https://github.com/upbound/provider-azure/blob/651e87e6e723bca55c8b1e0630b42825967b405e/examples/apimanagement/testhooks/delete-logger.sh#L7

examples/hdinsight/testhooks/delete-hadoopcluster.sh Outdated
#!/usr/bin/env bash
set -aeuo pipefail

# the HadoopCluster resource should be deleted before Container
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# the HadoopCluster resource should be deleted before Container
# the HadoopCluster resource should be deleted before Account

Should this comment be updated because the hook is in the Account resource?
Also please check other comments in the other hooks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@svscheg svscheg force-pushed the hardwaresecuritymodules_hdinsight_healthbot_healthcare branch from e531ab1 to d49c997 Compare February 8, 2023 15:25
@svscheg svscheg force-pushed the hardwaresecuritymodules_hdinsight_healthbot_healthcare branch from d49c997 to 81522c5 Compare February 8, 2023 15:45
@svscheg svscheg merged commit 28fcd58 into crossplane-contrib:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkenf turkenf turkenf approved these changes

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving hdinsight(5), healthbot(1), healthcare(3) resources to v1beta1 version
2 participants
@svscheg @turkenf