Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving datafactory(6) resources to v1beta1 version #234

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

steperchuk
Copy link
Contributor

@steperchuk steperchuk commented Jan 26, 2023

Description of your changes

Moving 6 resources in the datafactory group

Fixes #221

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually
Resources require account connectopn string to be specified

azurerm_data_factory_linked_custom_service
azurerm_data_factory_linked_custom_service

azurerm_data_factory_linked_service_azure_blob_storage
azurerm_data_factory_linked_service_azure_blob_storage

Manually and Uptest
examples/datafactory/integrationruntimeselfhosted.yaml
examples/datafactory/pipeline.yaml
examples/datafactory/triggerblobevent.yaml
examples/datafactory/triggerschedule.yaml

@steperchuk
Copy link
Contributor Author

/test-examples="examples/datafactory/integrationruntimeselfhosted.yaml"

@steperchuk
Copy link
Contributor Author

/test-examples="examples/datafactory/pipeline.yaml"

@steperchuk
Copy link
Contributor Author

/test-examples="examples/datafactory/triggerblobevent.yaml"

@steperchuk
Copy link
Contributor Author

/test-examples="examples/datafactory/triggercustomevent.yaml"

@steperchuk
Copy link
Contributor Author

/test-examples="examples/datafactory/triggerschedule.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steperchuk LGTM!

@steperchuk steperchuk merged commit a65242f into crossplane-contrib:main Jan 26, 2023
@steperchuk steperchuk deleted the issue-221 branch January 26, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving datafactory(6) resources to v1beta1 version
2 participants