Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure batch without testing #109

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

tomaszwostal
Copy link
Contributor

Description of your changes

Configure batch without testing

I have:

  • Run make reviewable test to ensure this PR is ready for review.

@Upbound-CLA
Copy link

Upbound-CLA commented Jan 2, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tomaszwostal thank you for this contribution it is very much appreciated.

Let me describe the resource configuration flow. Firstly, we do external name configuration for the resource without testing. We are adding these configurations to the config/externalnamenottested.go. In this step these resources are not generated and added to the provider.

Then as a second step, we are starting to generate and test the resources by moving them to the config/externalname.go. If the tests are successfully completed for these resources, we remove the resource from not tested file.

Again thank you very much for your contribution. Let's address the comments. If you have any question please let me know.

config/externalnamenottested.go Outdated Show resolved Hide resolved
config/externalnamenottested.go Outdated Show resolved Hide resolved
config/externalnamenottested.go Outdated Show resolved Hide resolved
config/externalnamenottested.go Outdated Show resolved Hide resolved
config/externalnamenottested.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomaszwostal LGTM!

@sergenyalcin sergenyalcin merged commit c0dbf3b into crossplane-contrib:main Jan 10, 2023
@tomaszwostal tomaszwostal deleted the configure-batch branch January 12, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants