Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storage ManagementPolicy #108

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

ytsarev
Copy link
Collaborator

@ytsarev ytsarev commented Jan 2, 2023

Description of your changes

Fixes #107

Signed-off-by: Yury Tsarev yury@upbound.io

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

uptest below

Fixes crossplane-contrib#107

Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev
Copy link
Collaborator Author

ytsarev commented Jan 2, 2023

/test-examples="examples/storage/blob.yaml,examples/storage/managementpolicy.yaml"

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ytsarev, lgtm.

@ytsarev ytsarev merged commit 8f92c5f into crossplane-contrib:main Jan 2, 2023
@ytsarev ytsarev deleted the fix-mgmt-policy branch January 2, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Storage: ManagementPolicy not working
2 participants