AWS Go SDK v1 connection method for ACK-generated resources #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
26 tasks
5 tasks
…es necessary authorization methods that use v1 SDK. Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
muvaf
force-pushed
the
ack-v1-connect
branch
from
afc1508 to
f06bf7c
Compare
…S Go SDK v1 Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
muvaf
force-pushed
the
ack-v1-connect
branch
from
f06bf7c to
db0cdbc
Compare
wolffbe
pushed a commit
to wolffbe/provider-aws
that referenced
this pull request
Feb 12, 2021
AWS Go SDK v1 connection method for ACK-generated resources
namku
pushed a commit
to namku/provider-aws
that referenced
this pull request
Mar 9, 2021
AWS Go SDK v1 connection method for ACK-generated resources
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
[provider-aws]: Update the authentication guide
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
…l-networkmanager Moving networkfirewall(2), networkmanager(9) resources to v1beta1 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We will be using ACK code generation pipeline to add new resources to
provider-awsbut ACK and generated code works with AWS Go SDK v1 whereas we use v2. One place they differ is how they authorize. This PR adds a function specific to v1.Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Not tested yet with an actual controller.