Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17 do not report secret on error, add github action #18

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Conversation

creharmony
Copy link
Owner

@creharmony creharmony commented Mar 31, 2021

Fix #17 do not report secret on error, add github action

stay TODO:

  • patch workflow
  • minor workflow
  • publish step for npmjs branch only
  • remove travis
  • how to declare security commit/fix ? cf. under.
  • created advisory: GHSA-xw22-wv29-3299

How to declare vulerability :

@github-actions
Copy link
Contributor

Total Coverage: 44.00%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   EtsyClient.js47.83%37.04%44%10, 116, 120, 122, 123, 128, 128, 128, 130, 133, 135, 135, 135, 136, 136, 136, 136, 136, 136, 138, 142, 142, 142, 143, 145, 152, 153, 154, 155, 155, 155, 155, 155, 156, 157, 157, 157, 158, 160, 165, 165, 165, 166, 168, 30, 31, 36, 37, 42, 43, 48, 49, 54, 55, 60, 61, 66, 67, 72, 73, 78, 79, 80, 86, 87, 95

@creharmony creharmony requested a review from boly38 March 31, 2021 19:00
@creharmony creharmony marked this pull request as ready for review March 31, 2021 19:00
@creharmony creharmony merged commit b4beb8e into main Mar 31, 2021
@creharmony creharmony deleted the 17 branch March 31, 2021 19:03
@boly38 boly38 self-assigned this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On connect error secret appears in error
2 participants