Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rTorrent: Improve session saving #242

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

stickz
Copy link
Contributor

@stickz stickz commented May 11, 2023

This commit improves session saving support for rTorrent to prevent unnecessary loss of torrent files. It also increases the session saving interval from 20 minutes to 1 hour to reduce disk i/o usage with thousands of torrents. Session saving is a very intensive task. Torrents fail to save into session by default when added and can be lost if a crash occurs between saving intervals.

@stickz stickz requested a review from crazy-max as a code owner May 11, 2023 02:10
This commit improves session saving support for rTorrent to prevent unnecessary loss of torrent files. It also increases the session saving interval from 20 minutes to 1 hour to reduce disk i/o usage with thousands of torrents. Session saving is a very intensive task and torrents fail to save into session by default when added.
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit c45955a into crazy-max:master May 17, 2023
@BloodyIron
Copy link

Sessions still aren't saving for me even though my pod runs for hours on end. Every time the pod gets remade (for reasons unrelated) I have to rescan every single Torrent in full.

@stickz
Copy link
Contributor Author

stickz commented Oct 2, 2023

Sessions still aren't saving for me even though my pod runs for hours on end. Every time the pod gets remade (for reasons unrelated) I have to rescan every single Torrent in full.

It's not related to this pull request. All it does is override the default session saving intervals. I would file a bug report elsewhere.

@stickz stickz deleted the patch-4 branch October 2, 2023 18:35
@BloodyIron
Copy link

BTW the session saving issue on my end was addressed by switching from underlying storage from NAS connected via SMB, changing that to NFS (v3 in my case for both of those protocols). So just wanted to let you know @stickz for other humans that might get stuck too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants