Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Force tan input field to be ordered left-to-right even for RTL languages #919

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

johannesrohwer
Copy link
Member

This small PR makes sure that the tan input field is always displayed from left-to-right even for languages that are RTL (such as Arabic, see discussion JIRA 1734).

Checklist

  • This PR does not change text that hasn't been signed off with the RKI. Have a look at the pinned issue 440
  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed.
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)

Description

@johannesrohwer johannesrohwer added the enhancement Improvement of an existing feature label Jul 17, 2020
@johannesrohwer johannesrohwer requested review from steins-code and a team July 17, 2020 13:32
Copy link
Member

@melloskitten melloskitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thank you for your glorious submission. hooray! 🎉

@johannesrohwer johannesrohwer merged commit bd03e27 into develop Jul 20, 2020
@johannesrohwer johannesrohwer deleted the feature/tan-input-for-rtl-languages branch July 20, 2020 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants