Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Remove precondition failure for Production #5164

Merged
merged 1 commit into from
May 1, 2023

Conversation

30mar
Copy link
Contributor

@30mar 30mar commented May 1, 2023

Description

We had a Precondition Failure in case we run on a scheme other than Production in en the MockEnaManager.

  • Is it safe to remove this line?
  • this line was to avoid using ENAManager with no functionalities which didn't make sense back in the time it was written but now it is the case we need as we don't need any actual functionalities for the ramp down after 1.5.2023,

To reproduce the crash Just change if #Prod to if #debug. in the MockENManager class.

To test that the solution is working remove the line as done in the PR, the app will start normally

Jira Link:

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-15088

@30mar 30mar added the bug Something isn't working label May 1, 2023
@30mar 30mar added this to the v3.2.0 milestone May 1, 2023
@30mar 30mar requested a review from a team May 1, 2023 08:41
@30mar 30mar merged commit 31c18c0 into release/3.2.x May 1, 2023
@30mar 30mar deleted the fix/fix-production-crash-on-mockENAManager branch May 1, 2023 08:57
@Ein-Tim Ein-Tim mentioned this pull request May 1, 2023
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants