This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix/10829 Duration Picker Auto Scroll #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @puneetmahali1 since there are many hard coded values, could you also verify it for bigger sized devices and share the recording too? Thanks |
@naveeddotio: Sure, I have attached the bigger screen recording(iPhone 14 Pro max) there we don't need the auto scroll as we can see the picker view without it. |
naveeddotio
approved these changes
Feb 15, 2023
flxschmidt
approved these changes
Feb 16, 2023
| // If iPhone resolution height is less than or equal to 844 then the screen will auto scroll to see the event duration picker | ||
| // if the height is more than 844 then user can see the event duration picker without auto scroll. | ||
| // For screen resolution please see more details on: https://www.ios-resolution.com/ | ||
| if !viewModel.temporaryDefaultLengthPickerIsHidden && UIScreen.main.bounds.size.height <= 667 { |
There was a problem hiding this comment.
Your solution is fixing the bug.
From the code base, I would prefer a common Helper class for device bounds (device resolutions).
Similar to that /~https://github.com/anatoliyv/AssistantKit
But at the moment your solution is fine for me
puneetmahali1
deleted the
fix/10829-broken-layout-for-duration-picker
branch
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Auto Scroll was missing on header tap on event duration picker and increase the auto scroll length
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-10829
Screenshots
EXPOSUREAPP-10829.mov
Recording for Bigger Screen
EXPOSUREAPP-10829.Bigger.Screen.mov