Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): avoid getting bigint as string in stats #86

Merged
merged 2 commits into from
Apr 21, 2024
Merged

fix(sql): avoid getting bigint as string in stats #86

merged 2 commits into from
Apr 21, 2024

Conversation

Hieuzest
Copy link
Contributor

@Hieuzest Hieuzest commented Apr 17, 2024 •
edited
Loading

No description provided.

@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (6a65bfc) to head (146bb05).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          38       38           
  Lines        9497     9501    +4     
  Branches     2429     2406   -23     
=======================================
+ Hits         9367     9371    +4     
  Misses        130      130

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hieuzest Hieuzest marked this pull request as draft April 17, 2024 06:59
@Hieuzest Hieuzest force-pushed the fix-sqlite-bigint branch from 6f7355c to 574ff45 Compare April 17, 2024 07:09
@Hieuzest Hieuzest changed the title fix(sqlite): set useBigInt only in get/eval fix(sqlite,mysql): avoid get bigint as string in stats Apr 17, 2024
@Hieuzest Hieuzest changed the title fix(sqlite,mysql): avoid get bigint as string in stats fix(sqlite,mysql): avoid getting bigint as string in stats Apr 17, 2024
@Hieuzest Hieuzest marked this pull request as ready for review April 17, 2024 07:32
@Hieuzest Hieuzest requested a review from shigma April 20, 2024 17:49
@shigma shigma changed the title fix(sqlite,mysql): avoid getting bigint as string in stats fix(sql): avoid getting bigint as string in stats Apr 21, 2024
@shigma shigma merged commit 38e2134 into cordiverse:master Apr 21, 2024
26 checks passed
@Hieuzest Hieuzest deleted the fix-sqlite-bigint branch April 27, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shigma shigma shigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hieuzest @shigma