Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect reference to vscoq.trace.server #974

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

cpitclaudel
Copy link
Contributor

The README and the settings say to use vscoq.trace.server, but AFAICT this setting does nothing. Looking at the code:

super(
'vscoq-language-server',
'Coq Language Server',
serverOptions,
clientOptions
);

… it appears that the right name is vscoq-language-server, not vscoq. Indeed, with that setting set, I do get a trace (and I don't with the normal one).

An alternative fix would be to change the snippet above to have vscoq instead of vscoq-language-server. Not sure what the consequences would be.

@rtetley rtetley force-pushed the cpc/fix-trace-setting branch from 4e7b548 to bb726bd Compare January 13, 2025 14:02
@rtetley
Copy link
Collaborator

rtetley commented Jan 13, 2025

Thanks ! Took the liberty of rebasing, will merge once CI passes !

@rtetley rtetley merged commit 36f5a39 into coq:main Jan 13, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants