-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pick for 8.19.2 with the Ltac2 debugger (preview) #429
Conversation
The opam file for coqide misses the dependency. The original one has it here: You should copy the original one and deviate from it only as much as required. |
9043500
to
df4aa06
Compare
OK, this works for me, I think it's good. If you merge soon, will this pick be included when you release CP 8.19? Thanks. |
@jfehrle : can you please rebase to latest main? |
798395e
to
cf00cd4
Compare
I think I got it. I had some misconfiguration for this git project :-( |
If you have no further comments, perhaps you could merge this soon? Thanks. |
28716f4
to
d37981a
Compare
I took out the doc commit and updated a few files to match 8.19.2. So I think ready now. |
@jfehrle : thanks! Sorry, there is one more thing I missed (I got interrupted during my last review): your pick file became outdated vs. main. When you rebase you need to manually merge over changes to variants of pick files. Please update your pick file to the changes in |
I think I got it, thanks. I can squash before the merge. |
@jfehrle : thanks - yes looks good. And yes, please squash. |
I cancel the CI run, so that the squashed CI run gets through faster (otherwise it would have to wait). |
0dff524
to
0b0c6e1
Compare
Squashed |
This works now.
I didn't include the patch file
PR19247-ported-Fix-coqide-compilation-with-lablgtk-3.1.5-on-windows.patch
because I previously included that commit in my branch.