Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Papr support #6

Merged
merged 6 commits into from
Nov 2, 2017
Merged

Add Papr support #6

merged 6 commits into from
Nov 2, 2017

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 1, 2017 •
edited
Loading

papr support copied in and modified from buildah

@cevich
Copy link
Member

cevich commented Nov 1, 2017

@mheon @rhatdan I made some comments #5 (review) that got lost. May be relevant here, I dunno.

@rhatdan rhatdan force-pushed the papr branch 6 times, most recently from 11cb7bb to 57a462a Compare November 2, 2017 15:12
@rhatdan
Copy link
Member Author

rhatdan commented Nov 2, 2017

@jlebon Any idea why papr is not running?

cgwalters
cgwalters reviewed Nov 2, 2017
View reviewed changes
.papr.sh

(mkdir -p $GOSRC && cd /code && cp -r . $GOSRC)

dnf install -y \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also /~https://github.com/ostreedev/ostree/blob/master/ci/libbuild.sh - once something is packaged then you can just do pkg_install_builddeps libpod.

.papr.yml
@@ -0,0 +1,15 @@
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still have auto and try here.

@rhatdan
Copy link
Member Author

rhatdan commented Nov 2, 2017

@cgwalters Any ideas why the papr tests are not running now?

@cevich
Copy link
Member

cevich commented Nov 2, 2017

@rhatdan jlebon's working on it.

@rh-atomic-bot
Copy link
Collaborator

💥 Invalid .papr.yml: file could not be parsed as valid YAML.

@rhatdan rhatdan force-pushed the papr branch 6 times, most recently from b145994 to 02016c2 Compare November 2, 2017 18:23
@rhatdan
Copy link
Member Author

rhatdan commented Nov 2, 2017

@jlebon Looks like I hung up papr again? Or it is just slow?

@jlebon
Copy link
Contributor

jlebon commented Nov 2, 2017

@rhatdan It's just slow :(. Push notifications aren't going through currently, so it can be 5-10 minutes before the next poll picks it up.

@rhatdan
Copy link
Member Author

rhatdan commented Nov 2, 2017

@jlebon Just tell me to "cool my jets" thanks.

@rhatdan
No man5 or man8 man pages
10006e7 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
-mFix crioConfigPath
83b55c4 
I don't believe this should be in here, but for now we need to make it not global
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Fix gofmt errors
92818fd 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan force-pushed the papr branch 3 times, most recently from c1b74a9 to 60b3280 Compare November 2, 2017 19:50
@rhatdan
Fix lint error on spec being shadowed
0847e77 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan force-pushed the papr branch 3 times, most recently from 6f17a43 to 89b5cff Compare November 2, 2017 21:43
@rhatdan
Add .papr support
f590429 
Don't run lint for now, since we seem to be running out of memory.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Remove tip from testing in yaml
6e37df1 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Nov 2, 2017

@cevich @mheon @baude PTAL

@baude
Copy link
Member

baude commented Nov 2, 2017

LGTM

@rhatdan
Copy link
Member Author

rhatdan commented Nov 2, 2017

@TomSweeneyRedHat PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Nov 2, 2017

@umohnani8 PTAL

@mheon
Copy link
Member

mheon commented Nov 2, 2017

Tests are green, LGTM!

@rhatdan rhatdan merged commit 7bb1d24 into containers:master Nov 2, 2017
@rh-atomic-bot rh-atomic-bot mentioned this pull request Nov 2, 2017
Closed
baude referenced this pull request in baude/podman Aug 31, 2019
Merge pull request #6 from squeed/merge-docs
dcf7368 
Documentation folder merge
jwhonce referenced this pull request in jwhonce/podman Nov 3, 2019
@baude
Merge pull request #6 from jwhonce/wip/apiv2
da8ec26 
Initial commit on compatible API
@coldbloodx coldbloodx mentioned this pull request Jul 23, 2020
Closed
@tyler92 tyler92 mentioned this pull request Jul 20, 2022
Merged
@rhatdan rhatdan deleted the papr branch December 1, 2022 22:02
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgwalters cgwalters cgwalters left review comments

Assignees
No one assigned
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhatdan @cevich @rh-atomic-bot @jlebon @baude @mheon @cgwalters