Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpod: fix rootless cgroup path with --cgroup-parent #23858

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

mmmmaeda
Copy link
Contributor

@mmmmaeda mmmmaeda commented Sep 4, 2024

The cgroup path following /sys/fs/cgroup/user.slice is not named user, but rather it is named after the parent slice.

Fixes #23780

Does this PR introduce a user-facing change?

Fixed a bug where rootless Podman could fail to start container with option --cgroup-parent ([#23780](/~https://github.com/containers/podman/issues/23780)).

Signed-off-by: Yuta Maeda <yuta.maeda.kc@hitachi.com>
@Luap99
Copy link
Member

Luap99 commented Sep 4, 2024

@giuseppe PTAL

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@giuseppe giuseppe added the No New Tests Allow PR to proceed without adding regression tests label Sep 4, 2024
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99, mmmmaeda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ca8d87e into containers:main Sep 4, 2024
80 checks passed
@ttyono ttyono deleted the fix-cgroup-path branch September 5, 2024 08:04
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 5, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to start pod with rootless container using --cgroup-parent
3 participants