Podman CLI --add-host with multiple host for a single IP #23802
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
| @@ -252,7 +253,8 @@ func parseExtraHosts(extraHosts []string, hostContainersInternalIP string) (Host | |||
| } | |||
| ip = hostContainersInternalIP | |||
| } | |||
| e := HostEntry{IP: ip, Names: []string{values[0]}} | |||
There was a problem hiding this comment.
you cannot change vendor code directly, this must be first submitted as PR in /~https://github.com/containers/common then we can update the dependency here
There was a problem hiding this comment.
Yes I've seen that, that's why I just opened this PR : containers/common#2139
So on this repository, I should just remove my changes from hosts.go ?
There was a problem hiding this comment.
As the PR has been merged, how do we proceed to include a version of the common library into this code ?
I've seen that it is defined there /~https://github.com/containers/podman/blob/main/go.mod#L16 and /~https://github.com/containers/podman/blob/main/vendor/modules.txt#L174
I guess someone from the core team has to create a new tag 0.60.3 and includes the commit in it and then we can refer to it in the previous files
There was a problem hiding this comment.
I let you know once we updated it in podman, likely sometime next week. We generally vendor based of the main branch during development so we do not need a new tag there.
There was a problem hiding this comment.
Hello @Luap99, any news on the previous point ?
There was a problem hiding this comment.
Sorry I was on PTO so I forget to update you here. Yes, you can rebase the change is vendored now.
There was a problem hiding this comment.
I guess I'm missing something here :
I don't see any new release of the common lib : /~https://github.com/containers/common/releases
And the dependency seems to still be defined in 0.60.1 : /~https://github.com/containers/podman/blob/main/go.mod#L16
There was a problem hiding this comment.
We vendor by commit during dev time on main, we only cut releases of the libs when we cut a new podman.
For example b9fe409.
You can check in the vendor/ directory your changes are in there.
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Signed-off-by: Jerome degroote <jeromedu59230@gmx.fr>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
I've rebased + added some tests so I guess the PR is now ready for review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerome59, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Hello,
Fixes #23770
I didn't update any tests because I don't know which one I should update and how to update them without breaking them.
It would be nice if someone creates the tests for me or give me some explanation on where and how I can create a test case.
Does this PR introduce a user-facing change?