Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Fix broken code block markup in Introduction.rst #20492

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[CI:DOCS] Fix broken code block markup in Introduction.rst #20492

merged 1 commit into from
Oct 26, 2023

Conversation

brlin-tw
Copy link
Contributor

@brlin-tw brlin-tw commented Oct 26, 2023 •
edited
Loading

This PR fixes the following defect in the documentation:

Screenshot

It is unclear whether this change warrants a release notes entry, so I added one regardless.

Does this PR introduce a user-facing change?

Fixed a broken code block markup in the Introduction chapter of the documentation

@brlin-tw
Fix broken code block markup in Introduction.rst
fd5140d 
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>

Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
Luap99
Luap99 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@TomSweeneyRedHat
Copy link
Member

Nice Eagle Eye @brlin-tw !
LGTM
/approved

@Luap99
Copy link
Member

Luap99 commented Oct 26, 2023

/lgtm
looks like to bot did not add the label before

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@Luap99 Luap99 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brlin-tw, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit e5101b2 into containers:main Oct 26, 2023
42 checks passed
@brlin-tw brlin-tw deleted the patch-1 branch October 26, 2023 20:46
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brlin-tw @TomSweeneyRedHat @Luap99