Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image history: fix walking layers #20381

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

vrothberg
Copy link
Member

libimage did not walk thte layers correctly which was probably inherited by old Podman code. Fix that by vendoring in the corresponding changes in c/common.

Fixes: #20375

Does this PR introduce a user-facing change?

Fix a bug in `podman history` not displaying the sizes of certain layers.

@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2023
@vrothberg
Copy link
Member Author

Once green we can merge the PR in c/common containers/common#1697 and revendor.

libimage did not walk thte layers correctly which was probably
inherited by old Podman code.  Fix that by vendoring in the
corresponding changes in c/common.

Fixes: containers#20375
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@vrothberg vrothberg marked this pull request as ready for review October 18, 2023 07:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@vrothberg
Copy link
Member Author

Now vendoring in c/common@main. Ready to merge once green.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Oct 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci openshift-ci bot merged commit ef2392f into containers:main Oct 18, 2023
@vrothberg vrothberg deleted the fix-20375 branch October 18, 2023 11:06
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API: /v1.24/images/${img}/history contains "Size":0 where docker has "Size":7458929
3 participants