Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WireGuard Support #16291

Closed
wants to merge 2 commits into from
Closed

WireGuard Support #16291

wants to merge 2 commits into from

Conversation

b-m-f
Copy link

@b-m-f b-m-f commented Oct 25, 2022

Draft PR to get containers/netavark#450 implemented

Does this PR introduce a user-facing change?

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

@b-m-f: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Oct 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: b-m-f
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval by writing /assign @giuseppe in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@b-m-f b-m-f mentioned this pull request Oct 27, 2022
Closed
@b-m-f b-m-f force-pushed the wireguard branch 2 times, most recently from 91cae17 to bd2ba5f Compare November 13, 2022 09:33
b-m-f added 2 commits November 13, 2022 10:35
@b-m-f
misc: fixes typo
45bcca7 
Signed-off-by: b-m-f <max@ehlers.berlin>
@b-m-f
feat: adds support for WireGuard network type
f751e40 
Signed-off-by: b-m-f <max@ehlers.berlin>
@b-m-f
Copy link
Author

b-m-f commented Nov 13, 2022

This PR is now ready for review.

This feature is spread over 3 PRs:

@b-m-f b-m-f marked this pull request as ready for review November 13, 2022 09:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2022
@b-m-f b-m-f mentioned this pull request Nov 13, 2022
Closed
TomSweeneyRedHat
TomSweeneyRedHat reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
assuming happy tests

@openshift-merge-robot
Copy link
Collaborator

@b-m-f: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2022
@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@b-m-f b-m-f marked this pull request as draft January 17, 2023 13:27
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
@rhatdan
Copy link
Member

rhatdan commented Jan 19, 2023

@b-m-f are you still interested in this? If not I will close.

@b-m-f
Copy link
Author

b-m-f commented Jan 19, 2023

Hi @rhatdan ,

i sure am. containers/netavark#472 is waiting for official plugin support in netavark.

Until that is all done i cant say whether the changes in this PR will stay as they are.

@github-actions github-actions bot removed the stale-pr label Jan 20, 2023
@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@b-m-f
Copy link
Author

b-m-f commented May 2, 2023

Implemented with netvarks plugin feature and /~https://github.com/b-m-f/netavark-wireguard-plugin

@b-m-f b-m-f closed this May 2, 2023
@b-m-f b-m-f deleted the wireguard branch May 2, 2023 06:28
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b-m-f @openshift-merge-robot @rhatdan @TomSweeneyRedHat