pod create --share none should not create infra

[cdoern]

for podman pod create, when we are not sharing any namespaces there is no point for the infra container.
This is especially true since resources have also been decoupled from the container recently.

handle this on the cmd level so that we can still create infra if set explicitly

resolves #15048

Signed-off-by: Charlie Doern cdoern@redhat.com

Does this PR introduce a user-facing change?

when using podman pod create --share, if --share=none or --share="" is specified, the pod's infra container is not created

[Luap99]

Also your release note does not make sense if you read it without the context of this PR. Please mention the command podman pod create

[TomSweeneyRedHat]

LGTM
and happy green test buttons

[rhatdan]

@Luap99 PTAL

[Luap99]

code LGTM but the release note line should be changed. It does not make much sense when you read it as one line without additional context.

[cdoern]

@Luap99 is that note better?

[Luap99]

SGTM but do we need correct capitalization and punctuation, @mheon @edsantiago?

[Luap99]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

@Luap99 this merged before I got a chance to look at it; and now that I'm looking, I don't know what capitalization you refer to. If this needs (or might need) a followup PR, could you please elaborate? If not, no problem.

[Luap99]

I am talking about the release notes block, we can change it after it merges AFAIK.

[mheon]

Yes, perfectly fine to do that.