Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bud-...-base-as-default : fix dup-arm flake #4521

Closed
wants to merge 1 commit into from

Conversation

edsantiago
Copy link
Member

Some sort of weird error with duplicate "arm" string in
manifest output. Started blowing up in podman CI today.

Fixes: #4520

Signed-off-by: Ed Santiago santiago@redhat.com

None

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

restarted the flaked jobs
@containers/podman-maintainers PTAL

@edsantiago
Copy link
Member Author

They're not flakes. Buildah is actually broken: #4503

@rhatdan
Copy link
Member

rhatdan commented Jan 17, 2023

@flouthoc PTAL

Some sort of weird error with duplicate "arm" string in
manifest output. Started blowing up in podman CI today.

Fixes: containers#4520

Signed-off-by: Ed Santiago <santiago@redhat.com>
@nalind
Copy link
Member

nalind commented Jan 17, 2023

No, the two "arm" values are pulled out of "linux/arm/v6" and "linux/arm/v7" stanzas, respectively. The test is right.

@edsantiago
Copy link
Member Author

Thanks. Closing, and leaving this in the hands of someone else.

@edsantiago edsantiago closed this Jan 17, 2023
@edsantiago edsantiago deleted the fix_dup_arm_flake branch January 17, 2023 19:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake: bud-multiple-platform-with-base-as-default-arg: duplicate 'arm'
4 participants