Add setProcessInput and deprecate setInput. #1034
Conversation
docs/tasks/Base.md
Outdated
| @@ -21,6 +21,7 @@ if ($this->taskExec('phpunit .')->run()->wasSuccessful()) { | |||
|
|
|||
| * `simulate($context)` {@inheritdoc} | |||
| * `setOutput($output)` Sets the Console Output. | |||
| * `setProcessInput($output)` Sets the input for the command. Similar to a pipe like `echo "input" | cat`. Usually followed by a call to `->interactive(false)` to avoid other inputs. | |||
There was a problem hiding this comment.
Typo, $output instead of $input.
This does not appear to be done, currently. Are you proposing that it should be? If there are no use cases where you need a tty with stdin redirection (seems reasonable to me), then the right time to make this behavior change would be now, when the new method name is introduced. The deprecated method should maintain the old behavior. |
|
Thanks for having a look. |
src/Common/ExecTrait.php
Outdated
| public function setInput($input) | ||
| { | ||
| trigger_error('setInput() is deprecated. Please use setProcessInput(().', E_USER_DEPRECATED); | ||
| return $this->setProcessInput($input); |
There was a problem hiding this comment.
setInput should maintain old behavior and not set interactive false
There was a problem hiding this comment.
This is probably not necessary but I can't prove that it won't cause a problem for someone.
There was a problem hiding this comment.
But you are right, better keep the same behavior for the deprecated method.
|
Thanks! |
Overview
This pull request:
Summary
Use a different method name to set the input for a process as the current one is overridden by the
InputAwareTraitused by theCollectionBuilderDescription
I was trying to provide a docker-compose.yml file via stdin by doing
but the
setInput()that ends up being called is not the one on theExecTraitso I propose to deprecate setInput as it wasn't working anyway and add a new method name that is more descriptive.I am not sure that
interactiveshould also be set to false automatically when you provide input for the process but that can be a discussion for another issue.