Add HumanCount and template keys to print position and length with co… #340
Conversation
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| use fmt::Write; | ||
|
|
||
| let num = self.0.to_string(); |
There was a problem hiding this comment.
There's almost certainly a more efficient implementation. Let me know if I should work on this or benchmark it
There was a problem hiding this comment.
Hmm, not sure there's an obviously more efficient implementation.
I do think the backwards counting loop variable is a little confusing, how about changing the loop to just use for (i, c) in num.chars().enumerate() and rename your current i to len (immutable), then maybe add a binding for let pos = len - i; or something?
There was a problem hiding this comment.
Agreed, I think the new version is a bit simpler. Another idea is to iterate in reverse, but then that requires reversing the output string
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| use fmt::Write; | ||
|
|
||
| let num = self.0.to_string(); |
There was a problem hiding this comment.
Hmm, not sure there's an obviously more efficient implementation.
I do think the backwards counting loop variable is a little confusing, how about changing the loop to just use for (i, c) in num.chars().enumerate() and rename your current i to len (immutable), then maybe add a binding for let pos = len - i; or something?
…mmas. #339
Motivation and trade-offs described in the issue. This was quite straightforward. Already using in alan-turing-institute/uatk-aspics@7332180, demo:
