use IConsumer/IProducer #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM - thanks! great catch. |
mhowlett
pushed a commit
that referenced
this pull request
Apr 11, 2019
mhowlett
pushed a commit
that referenced
this pull request
May 31, 2019
* PersistenceStatus not set correctly (#806) * use IConsumer/IProducer (#878) * add native methods from alpine-librdkafka.so (#883) * correct task awaiting with ConfigureAwait(false). also added ConfigureAwaitChecker.Analyzer package so you will have warnings in future * revert unnecessary whitespace changes * removed dependency
mhowlett
pushed a commit
that referenced
this pull request
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use interfaces in Set*Handler delegates