Add VulkanSceneGraph and vsgXchange #28730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jeongseok-meta
changed the title
to resolve: 2025-01-01T06:22:15.2415067Z ERROR (vsgxchange,Library/bin/vsgXchange.dll): $RPATH/libcurl.dll not found in packages, sysroot(s) nor the missing_dso_whitelist. 2025-01-01T06:22:15.2416520Z .. is this binary repackaging?
|
@conda-forge/help-c-cpp, ready for review! |
Otherwise: 2025-01-14T21:48:44.1803431Z ERROR (vsgxchange,lib/libvsgXchange.so.1.1.4): Needed DSO lib/libvulkan.so.1 found in ['conda-forge/linux-64::libvulkan-loader==1.3.296.0=h7ce02e2_0'] 2025-01-14T21:48:44.1804436Z ERROR (vsgxchange,lib/libvsgXchange.so.1.1.4): .. but ['conda-forge/linux-64::libvulkan-loader==1.3.296.0=h7ce02e2_0'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
... since it is not treated as a normal exit on Linux and segfaults on macOS. This utility is not critical, so it's not a significant issue if we don't test it.
2025-01-14T23:17:30.9437060Z (%PREFIX%) %SRC_DIR%>vsgconv.exe --version
2025-01-14T23:17:30.9649637Z VulkanSceneGraph version = 1.1.8, so = 14
2025-01-14T23:17:30.9650537Z vsgXchange version = 1.1.4, so = 1
2025-01-14T23:17:30.9651041Z vsgXchange built as shared library
2025-01-14T23:17:30.9685943Z
2025-01-14T23:17:30.9686826Z (%PREFIX%) %SRC_DIR%>IF 1 NEQ 0 exit /B 1
2025-01-14T23:17:30.9691324Z
2025-01-14T23:17:30.9691945Z (%PREFIX%) %SRC_DIR%>IF 1 NEQ 0 exit /B 1
2025-01-14T23:17:32.9102237Z WARNING: Tests failed for vsgxchange-1.1.4-h628fc26_0.conda - moving package to D:\bld\broken
2025-01-14T23:17:32.9831704Z Traceback (most recent call last):
2025-01-14T23:17:32.9833243Z File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3481, in test
2025-01-14T23:17:32.9882430Z utils.check_call_env(
2025-01-14T23:17:32.9883112Z File "D:\Miniforge\Lib\site-packages\conda_build\utils.py", line 406, in check_call_env
2025-01-14T23:17:32.9893498Z return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
2025-01-14T23:17:32.9897046Z ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-14T23:17:32.9897557Z File "D:\Miniforge\Lib\site-packages\conda_build\utils.py", line 382, in _func_defaulting_env_to_os_environ
2025-01-14T23:17:32.9899705Z raise subprocess.CalledProcessError(proc.returncode, _args)
2025-01-14T23:17:32.9900629Z subprocess.CalledProcessError: Command '['C:\\Windows\\system32\\cmd.exe', '/d', '/c', 'D:\\bld\\vsgxchange_1736896497233\\test_tmp\\conda_test_runner.bat']' returned non-zero exit status 1.
2025-01-14T23:17:32.9901231Z
2025-01-14T23:17:32.9901726Z During handling of the above exception, another exception occurred:
2025-01-14T23:17:32.9901991Z
2025-01-14T23:17:32.9902589Z Traceback (most recent call last):
2025-01-14T23:17:32.9903161Z File "D:\a\1\s\.ci_support\build_all.py", line 356, in <module>
2025-01-14T23:17:32.9909968Z build_all(os.path.join(root_dir, "recipes"), args.arch)
2025-01-14T23:17:32.9910757Z File "D:\a\1\s\.ci_support\build_all.py", line 185, in build_all
2025-01-14T23:17:32.9912647Z build_folders(recipes_dir, folders, arch, channel_urls)
2025-01-14T23:17:32.9913276Z File "D:\a\1\s\.ci_support\build_all.py", line 248, in build_folders
2025-01-14T23:17:32.9916816Z conda_build.api.build([recipe], config=get_config(arch, channel_urls))
2025-01-14T23:17:32.9918888Z File "D:\Miniforge\Lib\site-packages\conda_build\api.py", line 211, in build
2025-01-14T23:17:32.9941854Z return build_tree(
2025-01-14T23:17:32.9942886Z ^^^^^^^^^^^
2025-01-14T23:17:32.9943479Z File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3668, in build_tree
2025-01-14T23:17:32.9944042Z test(pkg, config=metadata.config.copy(), stats=stats)
2025-01-14T23:17:32.9944570Z File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3495, in test
2025-01-14T23:17:32.9945066Z tests_failed(
2025-01-14T23:17:32.9945594Z File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3542, in tests_failed
2025-01-14T23:17:32.9952899Z raise CondaBuildUserError("TESTS FAILED: " + os.path.basename(pkg))
2025-01-14T23:17:32.9953524Z conda_build.exceptions.CondaBuildUserError: TESTS FAILED: vsgxchange-1.1.4-h628fc26_0.conda
|
@conda-forge/help-c-cpp, ready for review! I've added checks for a header and library, but skipped the CLI tool run check. The tool doesn't report successful runs on Linux and Windows, even without errors, and segfaults on macOS. To ensure correct configuration, I've added a simple test program compilation using these CMake files to verify path correctness. |
xhochy
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).