Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip broken builds for now #116

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Conversation

henryiii
Copy link
Contributor

First step from #112. Follow up PRs can try enabling these again.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@henryiii henryiii requested a review from maxbachmann as a code owner August 25, 2022 12:58
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Old-style Python selectors (py27, py35, etc) are only available for Python 2.7, 3.4, 3.5, and 3.6. Please use explicit comparisons with the integer py, e.g. # [py==37] or # [py>=37]. See lines [16]

recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@henryiii
Copy link
Contributor Author

@conda-forge-admin, please rerender

@maxbachmann
Copy link
Contributor

I am not familar with the syntax for the exclusion. It appears we do now skip:

  • OSX arm64
  • pypy
  • python3.7

It would be great to restrict this further to:

  • OSX arm64
  • (pypy and Windows) or (pypy and Linux and (arm64 | ppc64le)
  • python3.7 and Linux and (arm64 | ppc64le)

@maxbachmann
Copy link
Contributor

@conda-forge-admin, please rerender

@henryiii
Copy link
Contributor Author

I copied what was in the issue, though I was wondering about why all 3.7 was being excluded.

@ngam
Copy link

ngam commented Aug 25, 2022

Not all 3.7 are problematic, but might as well skip because we will likely drop 3.7 soonish anyway...

@ngam
Copy link

ngam commented Aug 25, 2022

thanks!

@ngam
Copy link

ngam commented Aug 25, 2022

remember to also do jarowinkler

@maxbachmann maxbachmann merged commit e89fd1f into conda-forge:main Aug 25, 2022
@maxbachmann
Copy link
Contributor

I added the skip in jarowinkler as well: conda-forge/jarowinkler-feedstock#16

@henryiii henryiii deleted the patch-1 branch August 25, 2022 16:05
@maxbachmann
Copy link
Contributor

Not all 3.7 are problematic, but might as well skip because we will likely drop 3.7 soonish anyway...

@ngam is there any ETA for when Python 3.7 will be dropped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants