-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset depth when formatting differences #62
Conversation
Thinking about it, I don't think we should render with unlimited depth. But we could take the max depth and start counting at We should make that the default behavior, no option required. What do you think? |
I would be happy with either approach I guess, the depth is just too shallow currently... |
I implemented the current indent as offset, when a diff is reached.
for
|
@bunysae lovely, thanks! Could you submit your PR at https://issuehunt.io/r/concordancejs/concordance/issues/41? |
I will try to roll this into the next AVA release, probably this weekend. |
@novemberborn
Done. I'm looking forward to the next AVA release.
|
* Update dev dependencies * Test with TypeScript 3.9 * Update dependencies This includes a major update to Concordance, letting us print missing or extraneous objects in diffs with extra depth. See concordancejs/concordance#62. * Rebuild package-lock
As i mention in issue #41 just render the diff with unlimited depth would fix this issue. This can be done with the new option
renderDiffWithUnlimitedDepth
.Successor for PR #61.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: