-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boost-multi library #21179
base: master
Are you sure you want to change the base?
Add boost-multi library #21179
Conversation
This comment has been minimized.
This comment has been minimized.
@correaa Thank you for your first contribution! Please consider the follow points:
Please, read the contribution guide to get more information: /~https://github.com/conan-io/conan-center-index/tree/master/docs/adding_packages |
done. Regarding exporting local sources, I don’t understand what it means. |
got it. i had a typo in the filename and i had to remove version number. anything else? |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I see "403 Forbidden" when I try to look at the detail of the failed steps, such as |
@correaa The output log is only available by the Bot comment above: #21179 (comment) Those links listed on Gthub Check Status are not available. The bot indicated that you were not in the authorized list yet, but you should be listed there now. I'll restart the CI build, it should run good now. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 23 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
"0.80.1": | ||
url: https://gitlab.com/correaa/boost-multi/-/archive/v0.80.1/boost-multi-v0.80.1.tar.gz | ||
sha256: 7d1ebee123783e0fadfb58a0f55309148d63295fcb4b9c5442d851e3578cad1e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"0.80.1": | |
url: https://gitlab.com/correaa/boost-multi/-/archive/v0.80.1/boost-multi-v0.80.1.tar.gz | |
sha256: 7d1ebee123783e0fadfb58a0f55309148d63295fcb4b9c5442d851e3578cad1e | |
"0.83.0": | |
url: "https://gitlab.com/correaa/boost-multi/-/archive/v0.83.0/boost-multi-v0.83.0.tar.gz" | |
sha256: "52324a01e25fd66a32c8bf88f41940ba6364fd218cfab53b7ec5c63115dea1bf" |
I would recommend updating to 0.83.0, so the LICENSE file will be available.
Is it possible to have latest version of the library? is it not recommended? Ideally, I think the best is to have at least one named (versioned) version and latest (from master branch). Is that ok? |
@correaa You are the author, tell me you 😉 There is recommendation about version in CCI: /~https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conanfile_attributes.md#version The recommendation is adding only the latest version, then add old versions in case someone needs and open an issue asking. Each version could generate +100 packages, so is important save some resource from CI when possible. Consuming directly from master is allowed for those cases when the project is quiet for a long period, or, the project does not provide tags/releases. In your case, I would recommend providing the latest version. In case you have something more to be added from master, you could generate a patch version in your project, then use it. |
So a way to do this would be to always have a version (branch) called latest that is quasi in sync with master (e.g. manually maintained in github/gitlab) and add only that one to Conan? After that what would remain to be done? |
Not mandatory, but preferable.
Just update |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@correaa Hello! I made a few changes in your PR, so we can merge it. Sorry for the delay!
Please, feel free to comment about those changes and give your feedback! Regards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The recipe looks to be aligned to boost-multi 0.86.0
Thank you for your PR and for providing your project as a Conan package.
On the contrary, thank you for finishing this PR and sorry for dropping it before. Is it possible/recommended to install the current master instead or in addition to 0.86? what is the best way to test in my own CI if the conan package is |
@correaa Thank you for your questions.
In ConanCenterIndex we prefer always using the released versions, as they are controlled based on tags. Still, there are exceptions for those projects that do not provide a release for a long period or are barely maintained, both are not your case, as your project looks active and healthy. So it would not be possible in ConanCenterIndex.
The recipe in ConanCenterIndex right now for your project is really simple, as it only copies headers and license to the package and only build a small test package. You always can open a new issue asking for a version bump, as you have a new release, or even open a PR directly. You really do not need to predict the recipe for your project, but it's very kind, as most of cases we follow the upstream only. Still, if you wish to have a recipe pointing to the master branch, you could add a conanfile.py directly to your repository, and it should build the current branch. I could send a PR later to your project if you want. The Conan documentation shows how to build a Conan recipe when the source code is on the same place: https://docs.conan.io/2/tutorial/creating_packages/create_your_first_package.html
It does, the test_package is designed to validate the packaged headers, and libraries and check the linkage. It's not designed to run unit tests or feature validation, as it should be very minimal. The current test package in this PR imports headers, these are packaged by Conan. The license file, copied from your project, is in the I hope I could clarify to you how the packaging project process works in ConanCenterIndex. |
All this is great. Thank you. I will ask if any of my users want to use the library through Conan. LGTM, please merge when ready. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I though the next step was to merge this. Do I need to do something before that? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please merge if you think it is appropriate. |
Specify library name and version: b-multi/0.80.1
This is an attempt to the add the Multi library to Conan.
https://gitlab.com/correaa/boost-multi"