Guard fixOutput with setOutput instead of setInput #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
added a commit
to RyanGlScott/code-page
that referenced
this pull request
Feb 14, 2017
This is the same bug reported in commercialhaskell/stack#3002
snoyberg
approved these changes
Feb 20, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted the
fixCodePagefunction for use in my standalonecode-pagelibrary, and while doing so I noticed a small mix-up in its implementation.fixCodePageuses the internal functionsfixInputandfixOutputto actually change the input and output codepages respectively, but whilefixInputis guarded by the valuesetInput,fixOutputisn't guarded bysetOutput—it's guarded bysetInputtoo! This seems like a mistake, unless I'm mistaken.