Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql schema build removes spaces in file paths fixes #62 #117

Merged
merged 1 commit into from
May 25, 2020

Conversation

jugshaurya
Copy link
Contributor

Issue

fixes: #62

Solution

  • don't remove space using regex inside transformMap.

Working/Testing Screenshots - Fine

aloha

Checklist

PR will only be reviewed if the checklist is completed

  • I have done extensive testing for my changes.
  • I have self-reviewed my PR and removed all un-necessary changes.
  • My changes works well on both desktop and mobile environments.
  • I have made sure that my changes solves the actual problem mentioned in the issue.
  • The PR contains only 1 commit and have been updated with master.

@jugshaurya
Copy link
Contributor Author

jugshaurya commented May 24, 2020

@hereisnaman.
PR solution : works if you don't have any problem with removing the regex.

otherwise: I have to add inside the regex to ignore everything between double quotes and writing one more function to add doublequotes if path have spaces like this.

save

But I guess above solution works as I tested it on my laptop.

@jugshaurya
Copy link
Contributor Author

@hereisnaman please review

@thenamankumar
Copy link
Contributor

You simply need to wrap the dir names with spaces in quotes.

@jugshaurya
Copy link
Contributor Author

jugshaurya commented May 25, 2020

You simply need to wrap the dir names with spaces in quotes.

@hereisnaman, yes, I tried that but all those things that we discussed don't seem to work.
Here are the screenshots:

🔢version1: tried adding quotes => Your Approach
versionA

🔢version2: tried adding quotes and a backslash(I know both should have not come)
version2

🔢version3: tried only adding backslash
version3

🔢version4: tried only removing regex => Fixed and working => same as Earlier PR.
aloha

@thenamankumar thenamankumar merged commit 7334a99 into coding-blocks:master May 25, 2020
@boss-contributions-bot
Copy link

Congratualtions @jugshaurya, your pull request is merged! 🎉

Thanks for your contributions and participating in BOSS 2020. 🙌

You can claim your bounty points here. 💰

@thenamankumar
Copy link
Contributor

Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphql schema build removes spaces in file paths
2 participants