db: fix Open issue with single-item relative paths #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @sumeerbhola)
Previously Open with a relative path containing a single element would fail on real filesystems, because Open would attempt to open the empty path. Fix cockroachdb#3842.
jbowens
force-pushed
the
mkdirallandsyncparents
branch
from
6e0b655 to
4512006
Compare
|
TFTR! |
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Open with a relative path containing a single element would fail on real filesystems, because Open would attempt to open the empty path.
Fix #3509.